Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: Source/modules/accessibility/AXTableRow.cpp

Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXTableColumn.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 return 0; 109 return 0;
110 110
111 return headers[0].get(); 111 return headers[0].get();
112 } 112 }
113 113
114 void AXTableRow::headerObjectsForRow(AccessibilityChildrenVector& headers) 114 void AXTableRow::headerObjectsForRow(AccessibilityChildrenVector& headers)
115 { 115 {
116 if (!m_renderer || !m_renderer->isTableRow()) 116 if (!m_renderer || !m_renderer->isTableRow())
117 return; 117 return;
118 118
119 AccessibilityChildrenVector rowChildren = children(); 119 const AccessibilityChildrenVector& rowChildren = children();
120 unsigned childrenCount = rowChildren.size(); 120 unsigned childrenCount = rowChildren.size();
121 for (unsigned i = 0; i < childrenCount; i++) { 121 for (unsigned i = 0; i < childrenCount; i++) {
122 AXObject* cell = rowChildren[i].get(); 122 AXObject* cell = rowChildren[i].get();
123 if (!cell->isTableCell()) 123 if (!cell->isTableCell())
124 continue; 124 continue;
125 125
126 if (toAXTableCell(cell)->scanToDecideHeaderRole() == RowHeaderRole) 126 if (toAXTableCell(cell)->scanToDecideHeaderRole() == RowHeaderRole)
127 headers.append(cell); 127 headers.append(cell);
128 } 128 }
129 } 129 }
130 130
131 } // namespace blink 131 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXTableColumn.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698