Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 99173003: Use lowercase windows.h in includes to fix Windows cross compilation using mingw. (Closed)

Created:
7 years ago by cjacek
Modified:
7 years ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use lowercase windows.h in includes to fix Windows cross compilation using mingw. While it doesn't matter on Windows, mingw on case-sensitive OSes uses all lower case filenames for platform include files. I found the problem in SkCondVar.h from Mozilla checkout of skia sources, but the patch contains a fix for the whole skia tree. R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=12461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M bench/BenchSysTimer_windows.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/BenchSysTimer_windows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/LightSymbolsUtil/lightsymbols/lightsymbols.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkNativeGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkCondVar.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkWGL.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/win/SkAutoCoInitialize.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/win/SkIStream.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/win/SkNativeGLContext_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkDebug_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/win/SkAutoCoInitialize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/win/SkIStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/win/skia_win.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cjacek
7 years ago (2013-12-02 15:02:27 UTC) #1
bungeman-skia
lgtm Follow up that we may not care to do: We really shouldn't be including ...
7 years ago (2013-12-02 15:18:40 UTC) #2
bungeman-skia
Committed patchset #1 manually as r12461.
7 years ago (2013-12-03 15:23:45 UTC) #3
cjacek
7 years ago (2013-12-03 15:25:27 UTC) #4
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698