Don't cache any SkBitmaps in DeferredImageDecoder

Don't cache any SkBitmaps in DeferredImageDecoder

DeferredImageDecoder used to cache SkBitmaps for deferred decoded
images. This caused SkPixelRef to be referenced and memory are held by
Skia's image cache.

Instead DeferredImageDecoder shouldn't cache any SkBitmap. This is now
done entirely in BitmapImage. BitmapImage already has a policy when
an image exceeds 5MB it will clears its own cache. This will help to
free up memory for a large animated image.

DeferredImageDecoder used to mimic the ImageDecoder interface. Since
ImageSource uses this type directly there is no need for frameBufferAtIndex().
Instead DeferredImageDecoder simply returns a new NativeImageSkia.
Re-redecoding for progressive images and animations will be controlled
by BitmapImage and there is no need to cache.

Some minor cleanups are included:
* Remove unused methods from ImageSource and users.
* Move definition of animation types to ImageDecoder.h

Eventually ImageSource can be folded into BitmapImage or
DeferredImageDecoder.

BUG=429418
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191876

[Alpha Left Google, 2015-03-12 02:14:38]

hclam@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Alpha Left Google, 2015-03-13 18:33:59]

Ping.

[Stephen White, 2015-03-13 19:33:32]

Note that the compile failures on the android trybots seem to be related to this
change, and should be fixed before landing.

https://codereview.chromium.org/985583002/diff/40001/Source/platform/graphics...
File Source/platform/graphics/BitmapImage.h (right):

https://codereview.chromium.org/985583002/diff/40001/Source/platform/graphics...
Source/platform/graphics/BitmapImage.h:38: #include
"platform/image-decoders/ImageDecoder.h"
I assume this is for the repetition count enum?

Rather than add this (possibly large) dependency, could we pull the enum out
into its own file?

[Alpha Left Google, 2015-03-13 20:14:47]

On 2015/03/13 19:33:32, Stephen White wrote:
> Note that the compile failures on the android trybots seem to be related to
this
> change, and should be fixed before landing.

Android build fails at runhooks. Seems to be unrelated.

> 
>
https://codereview.chromium.org/985583002/diff/40001/Source/platform/graphics...
> File Source/platform/graphics/BitmapImage.h (right):
> 
>
https://codereview.chromium.org/985583002/diff/40001/Source/platform/graphics...
> Source/platform/graphics/BitmapImage.h:38: #include
> "platform/image-decoders/ImageDecoder.h"
> I assume this is for the repetition count enum?
> 
> Rather than add this (possibly large) dependency, could we pull the enum out
> into its own file?

Done.

[Stephen White, 2015-03-13 20:21:41]

LGTM w/nit

https://codereview.chromium.org/985583002/diff/60001/Source/platform/graphics...
File Source/platform/graphics/BitmapImage.cpp (right):

https://codereview.chromium.org/985583002/diff/60001/Source/platform/graphics...
Source/platform/graphics/BitmapImage.cpp:600: // because it is 0 (see comments
on its declaration in ImageDecoder.h).
ImageDecoder.h -> ImageAnimation.h

[Alpha Left Google, 2015-03-13 20:45:00]

On 2015/03/13 20:21:41, Stephen White wrote:
> LGTM w/nit
> 
>
https://codereview.chromium.org/985583002/diff/60001/Source/platform/graphics...
> File Source/platform/graphics/BitmapImage.cpp (right):
> 
>
https://codereview.chromium.org/985583002/diff/60001/Source/platform/graphics...
> Source/platform/graphics/BitmapImage.cpp:600: // because it is 0 (see comments
> on its declaration in ImageDecoder.h).
> ImageDecoder.h -> ImageAnimation.h

Done.

[Alpha Left Google, 2015-03-13 20:52:38]

The CQ bit was checked by hclam@chromium.org

[Alpha Left Google, 2015-03-13 20:52:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/985583002/#ps100001
(title: "merged")

[commit-bot: I haz the power, 2015-03-13 20:52:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985583002/100001

[commit-bot: I haz the power, 2015-03-13 21:32:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-13 21:32:13]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)

[Alpha Left Google, 2015-03-13 23:11:19]

The CQ bit was checked by hclam@chromium.org

[Alpha Left Google, 2015-03-13 23:11:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/985583002/#ps120001
(title: "done now")

[commit-bot: I haz the power, 2015-03-13 23:11:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985583002/120001

[commit-bot: I haz the power, 2015-03-14 05:00:26]

Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191876