Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Side by Side Diff: Source/core/fetch/ImageResourceTest.cpp

Issue 985583002: Don't cache any SkBitmaps in DeferredImageDecoder (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: done now Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/fetch/ImageResource.cpp ('k') | Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 cachedImage->finish(); 212 cachedImage->finish();
213 ASSERT_FALSE(cachedImage->errorOccurred()); 213 ASSERT_FALSE(cachedImage->errorOccurred());
214 ASSERT_TRUE(cachedImage->hasImage()); 214 ASSERT_TRUE(cachedImage->hasImage());
215 ASSERT_FALSE(cachedImage->image()->isNull()); 215 ASSERT_FALSE(cachedImage->image()->isNull());
216 ASSERT_EQ(client.imageChangedCount(), 1); 216 ASSERT_EQ(client.imageChangedCount(), 1);
217 ASSERT_TRUE(client.notifyFinishedCalled()); 217 ASSERT_TRUE(client.notifyFinishedCalled());
218 218
219 HashSet<ImageResource*> bitmapImages; 219 HashSet<ImageResource*> bitmapImages;
220 ASSERT_TRUE(cachedImage->image()->isBitmapImage()); 220 ASSERT_TRUE(cachedImage->image()->isBitmapImage());
221 bitmapImages.add(cachedImage.get()); 221 bitmapImages.add(cachedImage.get());
222
223 // Updating bitmap resources produces image changed callbacks on their clien ts.
224 ImageResource::updateBitmapImages(bitmapImages);
225 ASSERT_EQ(client.imageChangedCount(), 2);
226 ImageResource::updateBitmapImages(bitmapImages, true);
227 ASSERT_EQ(client.imageChangedCount(), 3);
228 } 222 }
229 223
230 } // namespace 224 } // namespace
OLDNEW
« no previous file with comments | « Source/core/fetch/ImageResource.cpp ('k') | Source/platform/blink_platform.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698