Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: Source/core/fetch/ImageResource.cpp

Issue 985583002: Don't cache any SkBitmaps in DeferredImageDecoder (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: done now Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/fetch/ImageResource.h ('k') | Source/core/fetch/ImageResourceTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 memoryCache()->remove(this); 383 memoryCache()->remove(this);
384 return; 384 return;
385 } 385 }
386 386
387 // It would be nice to only redraw the decoded band of the image, but wi th the current design 387 // It would be nice to only redraw the decoded band of the image, but wi th the current design
388 // (decoding delayed until painting) that seems hard. 388 // (decoding delayed until painting) that seems hard.
389 notifyObservers(); 389 notifyObservers();
390 } 390 }
391 } 391 }
392 392
393 void ImageResource::updateBitmapImages(HashSet<ImageResource*>& images, bool red ecodeImages)
394 {
395 for (ImageResource* imageResource : images) {
396 if (!imageResource->hasImage() || imageResource->image()->isNull())
397 continue;
398 BitmapImage* image = toBitmapImage(imageResource->image());
399 if (redecodeImages)
400 image->resetDecoder();
401 imageResource->updateImage(image->isAllDataReceived());
402 }
403 }
404
405 void ImageResource::finishOnePart() 393 void ImageResource::finishOnePart()
406 { 394 {
407 if (m_loadingMultipartContent) 395 if (m_loadingMultipartContent)
408 clear(); 396 clear();
409 updateImage(true); 397 updateImage(true);
410 if (m_loadingMultipartContent) 398 if (m_loadingMultipartContent)
411 m_data.clear(); 399 m_data.clear();
412 Resource::finishOnePart(); 400 Resource::finishOnePart();
413 } 401 }
414 402
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 if (node && isHTMLImageElement(node)) { 542 if (node && isHTMLImageElement(node)) {
555 const AtomicString& urlString = toHTMLImageElement(node)->imageSourceURL (); 543 const AtomicString& urlString = toHTMLImageElement(node)->imageSourceURL ();
556 KURL url = node->document().completeURL(urlString); 544 KURL url = node->document().completeURL(urlString);
557 imageForContainer->setURL(url); 545 imageForContainer->setURL(url);
558 } 546 }
559 547
560 return imageForContainer.get(); 548 return imageForContainer.get();
561 } 549 }
562 550
563 } // namespace blink 551 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/fetch/ImageResource.h ('k') | Source/core/fetch/ImageResourceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698