Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. (Closed)

Created:
5 years, 9 months ago by viettrungluu
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. Etc., with miscellaneous fixes. (Next: Clean up namespaces in application_manager directory, move NativeRunner into its own file, move LoadAndRunNativeApplication() into that file, getting rid of the now-mysteriously-named dynamic_service_runner.*.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/47e2e354c1d15de1183525499d03157af5e2cbf3

Patch Set 1 #

Patch Set 2 : remove incorrect/flaky NOTREACHED() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -405 lines) Patch
M shell/BUILD.gn View 6 chunks +9 lines, -9 lines 0 comments Download
M shell/android/android_handler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M shell/android/native_viewport_application_loader.h View 1 chunk +1 line, -2 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/app_child_process.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M shell/app_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M shell/dynamic_service_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
D shell/in_process_dynamic_service_runner.h View 1 chunk +0 lines, -70 lines 0 comments Download
D shell/in_process_dynamic_service_runner.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D shell/in_process_dynamic_service_runner_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
A + shell/in_process_native_runner.h View 3 chunks +15 lines, -18 lines 0 comments Download
A + shell/in_process_native_runner.cc View 5 chunks +8 lines, -8 lines 0 comments Download
A + shell/in_process_native_runner_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M shell/launcher_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/native_runner_unittest.cc View 1 4 chunks +2 lines, -4 lines 0 comments Download
D shell/out_of_process_dynamic_service_runner.h View 1 chunk +0 lines, -67 lines 0 comments Download
D shell/out_of_process_dynamic_service_runner.cc View 1 chunk +0 lines, -73 lines 0 comments Download
A + shell/out_of_process_native_runner.h View 2 chunks +16 lines, -18 lines 0 comments Download
A + shell/out_of_process_native_runner.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M shell/shell_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M shell/shell_test_base_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M shell/shell_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 9 months ago (2015-03-04 23:16:04 UTC) #1
jamesr
lgtm
5 years, 9 months ago (2015-03-04 23:19:05 UTC) #2
viettrungluu
5 years, 9 months ago (2015-03-05 00:38:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
47e2e354c1d15de1183525499d03157af5e2cbf3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698