shell/android/native_viewport_application_loader.h - Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/android/native_viewport_application_loader.h

Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: remove incorrect/flaky NOTREACHED() Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/android/native_viewport_application_loader.h

diff --git a/shell/android/native_viewport_application_loader.h b/shell/android/native_viewport_application_loader.h

index e5b27df989afa617765901b20711ff25080674ff..900b09f3627881c7e4cb4050118c85547e505113 100644

--- a/shell/android/native_viewport_application_loader.h

+++ b/shell/android/native_viewport_application_loader.h

@@ -34,8 +34,7 @@ class NativeViewportApplicationLoader : public ApplicationLoader,

InterfaceRequest<Application> application_request) override;

// ApplicationDelegate implementation.

- bool ConfigureIncomingConnection(

- mojo::ApplicationConnection* connection) override;

+ bool ConfigureIncomingConnection(ApplicationConnection* connection) override;

// InterfaceFactory<NativeViewport> implementation.

void Create(ApplicationConnection* connection,