Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: shell/in_process_dynamic_service_runner.h

Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove incorrect/flaky NOTREACHED() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/dynamic_service_runner.cc ('k') | shell/in_process_dynamic_service_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/in_process_dynamic_service_runner.h
diff --git a/shell/in_process_dynamic_service_runner.h b/shell/in_process_dynamic_service_runner.h
deleted file mode 100644
index 3d23613633f656a153c8d96de3cd5f6da1eb84b7..0000000000000000000000000000000000000000
--- a/shell/in_process_dynamic_service_runner.h
+++ /dev/null
@@ -1,70 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_
-#define SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_
-
-#include "base/callback.h"
-#include "base/files/file_path.h"
-#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/scoped_native_library.h"
-#include "base/threading/simple_thread.h"
-#include "shell/application_manager/application_manager.h"
-#include "shell/dynamic_service_runner.h"
-
-namespace mojo {
-namespace shell {
-
-class Context;
-
-// TODO(vtl): Rename this to "InProcessNativeRunner".
-// An implementation of |DynamicServiceRunner| that loads/runs the given app
-// (from the file system) on a separate thread (in the current process).
-class InProcessDynamicServiceRunner
- : public NativeRunner,
- public base::DelegateSimpleThread::Delegate {
- public:
- explicit InProcessDynamicServiceRunner(Context* context);
- ~InProcessDynamicServiceRunner() override;
-
- // |DynamicServiceRunner| method:
- void Start(const base::FilePath& app_path,
- NativeRunner::CleanupBehavior cleanup_behavior,
- InterfaceRequest<Application> application_request,
- const base::Closure& app_completed_callback) override;
-
- private:
- // |base::DelegateSimpleThread::Delegate| method:
- void Run() override;
-
- base::FilePath app_path_;
- NativeRunner::CleanupBehavior cleanup_behavior_;
- InterfaceRequest<Application> application_request_;
- base::Callback<bool(void)> app_completed_callback_runner_;
-
- base::ScopedNativeLibrary app_library_;
- scoped_ptr<base::DelegateSimpleThread> thread_;
-
- DISALLOW_COPY_AND_ASSIGN(InProcessDynamicServiceRunner);
-};
-
-class InProcessDynamicServiceRunnerFactory : public NativeRunnerFactory {
- public:
- explicit InProcessDynamicServiceRunnerFactory(Context* context)
- : context_(context) {}
- ~InProcessDynamicServiceRunnerFactory() override {}
-
- scoped_ptr<NativeRunner> Create(const Options& options) override;
-
- private:
- Context* const context_;
-
- DISALLOW_COPY_AND_ASSIGN(InProcessDynamicServiceRunnerFactory);
-};
-
-} // namespace shell
-} // namespace mojo
-
-#endif // SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_
« no previous file with comments | « shell/dynamic_service_runner.cc ('k') | shell/in_process_dynamic_service_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698