Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: shell/android/android_handler.cc

Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove incorrect/flaky NOTREACHED() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/BUILD.gn ('k') | shell/android/native_viewport_application_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/android_handler.cc
diff --git a/shell/android/android_handler.cc b/shell/android/android_handler.cc
index a103327f392fafc86f7863419dafe9f163fa52d3..916d9f788ed4795345975b994ca5cf670faa8e00 100644
--- a/shell/android/android_handler.cc
+++ b/shell/android/android_handler.cc
@@ -25,6 +25,7 @@ using base::android::GetApplicationContext;
namespace mojo {
namespace {
+
// This function loads the application library, sets the application context and
// thunks and calls into the application MojoMain. To ensure that the thunks are
// set correctly we keep it in the Mojo shell .so and pass the function pointer
@@ -33,8 +34,8 @@ void RunAndroidApplication(JNIEnv* env,
jobject j_context,
const base::FilePath& app_path,
jint j_handle) {
- InterfaceRequest<Application> application_request = MakeRequest<Application>(
- MakeScopedHandle(mojo::MessagePipeHandle(j_handle)));
+ InterfaceRequest<Application> application_request =
+ MakeRequest<Application>(MakeScopedHandle(MessagePipeHandle(j_handle)));
// Load the library, so that we can set the application context there if
// needed.
@@ -67,6 +68,7 @@ void RunAndroidApplication(JNIEnv* env,
shell::LoadAndRunNativeApplication(app_path, NativeRunner::DeleteAppPath,
application_request.Pass()));
}
+
} // namespace
AndroidHandler::AndroidHandler() : content_handler_factory_(this) {
« no previous file with comments | « shell/BUILD.gn ('k') | shell/android/native_viewport_application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698