Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: shell/in_process_native_runner.cc

Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove incorrect/flaky NOTREACHED() Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/in_process_native_runner.h ('k') | shell/in_process_native_runner_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/in_process_dynamic_service_runner.h" 5 #include "shell/in_process_native_runner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback_helpers.h" 8 #include "base/callback_helpers.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
11 #include "base/threading/platform_thread.h" 11 #include "base/threading/platform_thread.h"
12 12
13 namespace mojo { 13 namespace mojo {
14 namespace shell { 14 namespace shell {
15 15
16 InProcessDynamicServiceRunner::InProcessDynamicServiceRunner(Context* context) 16 InProcessNativeRunner::InProcessNativeRunner(Context* context)
17 : cleanup_behavior_(NativeRunner::DontDeleteAppPath), 17 : cleanup_behavior_(NativeRunner::DontDeleteAppPath),
18 app_library_(nullptr) { 18 app_library_(nullptr) {
19 } 19 }
20 20
21 InProcessDynamicServiceRunner::~InProcessDynamicServiceRunner() { 21 InProcessNativeRunner::~InProcessNativeRunner() {
22 // It is important to let the thread exit before unloading the DSO (when 22 // It is important to let the thread exit before unloading the DSO (when
23 // app_library_ is destructed), because the library may have registered 23 // app_library_ is destructed), because the library may have registered
24 // thread-local data and destructors to run on thread termination. 24 // thread-local data and destructors to run on thread termination.
25 if (thread_) { 25 if (thread_) {
26 DCHECK(thread_->HasBeenStarted()); 26 DCHECK(thread_->HasBeenStarted());
27 DCHECK(!thread_->HasBeenJoined()); 27 DCHECK(!thread_->HasBeenJoined());
28 thread_->Join(); 28 thread_->Join();
29 } 29 }
30 } 30 }
31 31
32 void InProcessDynamicServiceRunner::Start( 32 void InProcessNativeRunner::Start(
33 const base::FilePath& app_path, 33 const base::FilePath& app_path,
34 mojo::NativeRunner::CleanupBehavior cleanup_behavior, 34 NativeRunner::CleanupBehavior cleanup_behavior,
35 InterfaceRequest<Application> application_request, 35 InterfaceRequest<Application> application_request,
36 const base::Closure& app_completed_callback) { 36 const base::Closure& app_completed_callback) {
37 app_path_ = app_path; 37 app_path_ = app_path;
38 cleanup_behavior_ = cleanup_behavior; 38 cleanup_behavior_ = cleanup_behavior;
39 39
40 DCHECK(!application_request_.is_pending()); 40 DCHECK(!application_request_.is_pending());
41 application_request_ = application_request.Pass(); 41 application_request_ = application_request.Pass();
42 42
43 DCHECK(app_completed_callback_runner_.is_null()); 43 DCHECK(app_completed_callback_runner_.is_null());
44 app_completed_callback_runner_ = 44 app_completed_callback_runner_ =
45 base::Bind(&base::TaskRunner::PostTask, base::MessageLoopProxy::current(), 45 base::Bind(&base::TaskRunner::PostTask, base::MessageLoopProxy::current(),
46 FROM_HERE, app_completed_callback); 46 FROM_HERE, app_completed_callback);
47 47
48 DCHECK(!thread_); 48 DCHECK(!thread_);
49 thread_.reset(new base::DelegateSimpleThread(this, "app_thread")); 49 thread_.reset(new base::DelegateSimpleThread(this, "app_thread"));
50 thread_->Start(); 50 thread_->Start();
51 } 51 }
52 52
53 void InProcessDynamicServiceRunner::Run() { 53 void InProcessNativeRunner::Run() {
54 DVLOG(2) << "Loading/running Mojo app in process from library: " 54 DVLOG(2) << "Loading/running Mojo app in process from library: "
55 << app_path_.value() 55 << app_path_.value()
56 << " thread id=" << base::PlatformThread::CurrentId(); 56 << " thread id=" << base::PlatformThread::CurrentId();
57 57
58 app_library_.Reset(LoadAndRunNativeApplication(app_path_, cleanup_behavior_, 58 app_library_.Reset(LoadAndRunNativeApplication(app_path_, cleanup_behavior_,
59 application_request_.Pass())); 59 application_request_.Pass()));
60 app_completed_callback_runner_.Run(); 60 app_completed_callback_runner_.Run();
61 app_completed_callback_runner_.Reset(); 61 app_completed_callback_runner_.Reset();
62 } 62 }
63 63
64 scoped_ptr<NativeRunner> InProcessDynamicServiceRunnerFactory::Create( 64 scoped_ptr<NativeRunner> InProcessNativeRunnerFactory::Create(
65 const Options& options) { 65 const Options& options) {
66 return make_scoped_ptr(new InProcessDynamicServiceRunner(context_)); 66 return make_scoped_ptr(new InProcessNativeRunner(context_));
67 } 67 }
68 68
69 } // namespace shell 69 } // namespace shell
70 } // namespace mojo 70 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/in_process_native_runner.h ('k') | shell/in_process_native_runner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698