Use Rotate*() functions instead of doing this manually.

Use Rotate*() functions instead of doing this manually.

Shouldn't make a difference in practice, but it's a bit more readable and it
gets the case of a 0 shift correct without undefined behavior.

BUG=463436
LOG=N

Committed: https://crrev.com/b97df837524de92ef91aa9b1639e1d02101769ff
Cr-Commit-Position: refs/heads/master@{#26975}

[Nico, 2015-03-04 05:32:19]

thakis@chromium.org changed reviewers:
+ jochen@chromium.org

[Nico, 2015-03-04 05:32:20]

Small follow-up.

[Benedikt Meurer, 2015-03-04 05:46:36]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-03-04 05:46:37]

LGTM. Thanks for the cleanup.

[Nico, 2015-03-04 05:51:05]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-03-04 05:51:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975283002/20001

[commit-bot: I haz the power, 2015-03-04 05:53:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-04 05:53:40]

Patchset 2 (id:??) landed as
https://crrev.com/b97df837524de92ef91aa9b1639e1d02101769ff
Cr-Commit-Position: refs/heads/master@{#26975}

[hans, 2015-03-04 06:02:51]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2015-03-04 06:02:51]

https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h
File src/base/bits.h (right):

https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h#newcode151
src/base/bits.h:151: // Precondition: 0 <= shift < 32
Any reason the preconditions are not some kind of assert or check?

[Nico, 2015-03-04 06:21:10]

https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h
File src/base/bits.h (right):

https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h#newcode151
src/base/bits.h:151: // Precondition: 0 <= shift < 32
On 2015/03/04 06:02:51, hans wrote:
> Any reason the preconditions are not some kind of assert or check?

I was worried that this might be performance-critical and things might get very
slow in debug builds. I don't know if that's true.