Improve AXTree unit tests.

Improve AXTree unit tests.

This is a follow-up to: https://codereview.chromium.org/966833002/

BUG=452607
Committed: https://crrev.com/ee2eaca573eea513492b0f7931a1dfeeb6af999e
Cr-Commit-Position: refs/heads/master@{#321170}

[dmazzoni, 2015-02-27 18:27:24]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2015-03-02 16:41:54]

The fix landed, so this is ready for review now.

[David Tseng, 2015-03-11 21:19:27]

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_generate...
File ui/accessibility/ax_generated_tree_unittest.cc (right):

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_generate...
ui/accessibility/ax_generated_tree_unittest.cc:65: for (int i = 0; i < n; i++) {
nit: ++i

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_tree_ser...
File ui/accessibility/ax_tree_serializer.h (right):

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_tree_ser...
ui/accessibility/ax_tree_serializer.h:331: // different now.
Please rebase.

[dmazzoni, 2015-03-17 17:47:32]

Rebased, PTAL

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_generate...
File ui/accessibility/ax_generated_tree_unittest.cc (right):

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_generate...
ui/accessibility/ax_generated_tree_unittest.cc:65: for (int i = 0; i < n; i++) {
On 2015/03/11 21:19:27, David Tseng wrote:
> nit: ++i

Done.

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_tree_ser...
File ui/accessibility/ax_tree_serializer.h (right):

https://codereview.chromium.org/967583002/diff/1/ui/accessibility/ax_tree_ser...
ui/accessibility/ax_tree_serializer.h:331: // different now.
On 2015/03/11 21:19:27, David Tseng wrote:
> Please rebase.

Done.

[David Tseng, 2015-03-18 16:15:01]

lgtm

https://codereview.chromium.org/967583002/diff/20001/ui/accessibility/tree_ge...
File ui/accessibility/tree_generator.cc (right):

https://codereview.chromium.org/967583002/diff/20001/ui/accessibility/tree_ge...
ui/accessibility/tree_generator.cc:17: for (int i = 2; i < node_count; i++)
nit: ++i (consistency)

https://codereview.chromium.org/967583002/diff/20001/ui/accessibility/tree_ge...
ui/accessibility/tree_generator.cc:22: for (int i = 2; i <= node_count; i++)
nit: You could just save the result of (n-1)! and *= node_count

https://codereview.chromium.org/967583002/diff/20001/ui/accessibility/tree_ge...
ui/accessibility/tree_generator.cc:29: TreeGenerator::TreeGenerator(int
max_node_count, bool permutations)
nit: use_permutation?

[dmazzoni, 2015-03-18 16:37:35]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-03-18 16:37:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/967583002/#ps40001 (title:
"Final feedback")

[commit-bot: I haz the power, 2015-03-18 16:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/967583002/40001

[commit-bot: I haz the power, 2015-03-18 16:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 16:50:49]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2015-03-18 17:15:13]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-03-18 17:15:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/967583002/#ps60001 (title:
"Update automation_apitest.cc")

[commit-bot: I haz the power, 2015-03-18 17:15:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/967583002/60001

[commit-bot: I haz the power, 2015-03-18 18:13:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-18 18:13:56]

Patchset 4 (id:??) landed as
https://crrev.com/ee2eaca573eea513492b0f7931a1dfeeb6af999e
Cr-Commit-Position: refs/heads/master@{#321170}