Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962413002: Add type for testing to interstitials. (Closed)

Created:
5 years, 9 months ago by meacer
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dzhioev+watch_chromium.org, grt+watch_chromium.org, jam, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type for testing to interstitials. This CL adds a |GetTypeForTesting| method to all interstitials. Tests can then assert that they got the actual interstitial they expect. BUG=458972 Committed: https://crrev.com/fc55bd5d8a100520bf11cef23143f1d4d88a2e15 Cr-Commit-Position: refs/heads/master@{#319294}

Patch Set 1 #

Patch Set 2 : Add missing file #

Patch Set 3 : Fix Android build #

Patch Set 4 : Fix android build #

Total comments: 7

Patch Set 5 : bauerb comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -33 lines) Patch
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/interstitials/security_interstitial_page.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 3 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 7 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/login/login_interstitial_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/login/login_interstitial_delegate.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page_unittest.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/interstitial_page_delegate.h View 2 chunks +7 lines, -1 line 0 comments Download
A + content/public/browser/interstitial_page_delegate.cc View 1 2 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
meacer
bauerb, felt: Can you PTAL?
5 years, 9 months ago (2015-03-03 00:25:11 UTC) #2
Bernhard Bauer
Nice! https://codereview.chromium.org/962413002/diff/60001/chrome/browser/supervised_user/supervised_user_interstitial.h File chrome/browser/supervised_user/supervised_user_interstitial.h (right): https://codereview.chromium.org/962413002/diff/60001/chrome/browser/supervised_user/supervised_user_interstitial.h#newcode38 chrome/browser/supervised_user/supervised_user_interstitial.h:38: // content::InterstitialPageDelegate: Can you move this to the ...
5 years, 9 months ago (2015-03-03 09:56:00 UTC) #3
meacer
https://codereview.chromium.org/962413002/diff/60001/chrome/browser/supervised_user/supervised_user_interstitial.h File chrome/browser/supervised_user/supervised_user_interstitial.h (right): https://codereview.chromium.org/962413002/diff/60001/chrome/browser/supervised_user/supervised_user_interstitial.h#newcode38 chrome/browser/supervised_user/supervised_user_interstitial.h:38: // content::InterstitialPageDelegate: On 2015/03/03 09:56:00, Bernhard Bauer wrote: > ...
5 years, 9 months ago (2015-03-03 18:33:05 UTC) #4
meacer
Jochen: Can you also PTAL?
5 years, 9 months ago (2015-03-03 18:59:47 UTC) #6
felt
c/b/ssl/ and c/b/interstitials/ lgtm
5 years, 9 months ago (2015-03-03 19:06:23 UTC) #7
Bernhard Bauer
LGTM https://codereview.chromium.org/962413002/diff/60001/content/public/browser/interstitial_page_delegate.h File content/public/browser/interstitial_page_delegate.h (right): https://codereview.chromium.org/962413002/diff/60001/content/public/browser/interstitial_page_delegate.h#newcode50 content/public/browser/interstitial_page_delegate.h:50: virtual TypeID GetTypeForTesting() const; On 2015/03/03 18:33:05, Mustafa ...
5 years, 9 months ago (2015-03-03 21:40:51 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-05 16:56:12 UTC) #9
meacer
Thanks all.
5 years, 9 months ago (2015-03-05 18:20:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962413002/80001
5 years, 9 months ago (2015-03-05 18:20:57 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-05 19:12:20 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 19:12:57 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/fc55bd5d8a100520bf11cef23143f1d4d88a2e15
Cr-Commit-Position: refs/heads/master@{#319294}

Powered by Google App Engine
This is Rietveld 408576698