components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h - Issue 962413002: Add type for testing to interstitials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h

Issue 962413002: Add type for testing to interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bauerb comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/login/login_prompt_browsertest.cc ('k') | components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h

diff --git a/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h b/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h

index ea63a3fcdf2c0f6741f26e14793dd2ed612823fe..92d721d4f50d0dc2a7e5e0638014476c6ca48958 100644

--- a/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h

+++ b/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page.h

@@ -55,6 +55,9 @@ class DataReductionProxyDebugBlockingPage

~DataReductionProxyDebugBlockingPage() override;

+ // Interstitial type for testing.

+ static content::InterstitialPageDelegate::TypeID kTypeForTesting;

// Creates a blocking page. Use ShowBlockingPage when access to the blocking

// page directly isn't needed.

static DataReductionProxyDebugBlockingPage* CreateBlockingPage(

@@ -88,6 +91,7 @@ class DataReductionProxyDebugBlockingPage

void OnProceed() override;

void OnDontProceed() override;

void CommandReceived(const std::string& command) override;

+ content::InterstitialPageDelegate::TypeID GetTypeForTesting() const override;

protected:

friend class DataReductionProxyDebugBlockingPageFactoryImpl;