Add type for testing to interstitials.

content/public/browser/interstitial_page_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_INTERSTITIAL_PAGE_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_INTERSTITIAL_PAGE_DELEGATE_H_
 
 #include <string>
 
 #include "content/common/content_export.h"
 
 namespace content {
 
 class NavigationEntry;
 struct RendererPreferences;
 
 // Controls and provides the html for an interstitial page. The delegate is
 // owned by the InterstitialPage.
-class InterstitialPageDelegate {
+class CONTENT_EXPORT InterstitialPageDelegate {
  public:
+  // An identifier used to identify an InterstitialPage.
+  typedef const void* TypeID;
+
   virtual ~InterstitialPageDelegate() {}
 
   // Return the HTML that should be displayed in the page.
   virtual std::string GetHTMLContents() = 0;
 
   // Called when the interstitial is proceeded or cancelled. Note that this may
   // be called by content directly even if the embedder didn't call Proceed or
   // DontProceed on InterstitialPage, since navigations etc may cancel them.
   virtual void OnProceed() {}
   virtual void OnDontProceed() {}
 
   // Invoked when the page sent a command through DOMAutomation.
   virtual void CommandReceived(const std::string& command) {}
 
   // Invoked with the NavigationEntry that is going to be added to the
   // navigation controller.
   // Gives an opportunity to delegates to set states on the |entry|.
   // Note that this is only called if the InterstitialPage was constructed with
   // |new_navigation| set to true.
   virtual void OverrideEntry(content::NavigationEntry* entry) {}
 
   // Allows the delegate to override the renderer preferences structure that's
   // sent to the new RenderViewHost.
   virtual void OverrideRendererPrefs(content::RendererPreferences* prefs) {}
+
+  // Return the interstitial type for testing.
+  virtual TypeID GetTypeForTesting() const;

[Bernhard Bauer, 2015/03/03 09:56:00]

Do you really want to provide a default implementation instead of making it pure
virtual so that new interstitials are forced to add a type?

[meacer, 2015/03/03 18:33:05]

I started with a pure virtual method, but turns out we have a lot of tests that
create mock interstitials which would just return null. This seemed cleaner
since only the classes interested in testing the value need to implement it.

[Bernhard Bauer, 2015/03/03 21:40:51]

I'm more worried about the classes that are not testing it :) But fair enough.

 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_INTERSTITIAL_PAGE_DELEGATE_H_