Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4546)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 962413002: Add type for testing to interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bauerb comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index 6d427c1bd84b36229787569b2b9891facf31bf8d..93635732cdb236f76f99a5fd53a9825c31ec0ff6 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -57,7 +57,7 @@ class SSLBlockingPage : public SecurityInterstitialPage {
};
// Interstitial type, used in tests.
- static const void* kTypeForTesting;
+ static InterstitialPageDelegate::TypeID kTypeForTesting;
~SSLBlockingPage() override;
@@ -73,8 +73,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
const base::Time& time_triggered,
const base::Callback<void(bool)>& callback);
- // SecurityInterstitialPage method:
- const void* GetTypeForTesting() const override;
+ // InterstitialPageDelegate method:
+ InterstitialPageDelegate::TypeID GetTypeForTesting() const override;
// Returns true if |options_mask| refers to an overridable SSL error.
static bool IsOptionsOverridable(int options_mask);
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698