Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 962413002: Add type for testing to interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bauerb comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 424e516767f21073544df397dcb2e730f8ea38a4..ea9704bfdc9666c123277c37d6127964b1737aa7 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -37,6 +37,7 @@
#include "chrome/browser/interstitials/security_interstitial_metrics_helper.h"
#include "chrome/browser/interstitials/security_interstitial_page.h"
#include "chrome/browser/safe_browsing/ui_manager.h"
+#include "content/public/browser/interstitial_page_delegate.h"
#include "url/gurl.h"
class MalwareDetails;
@@ -53,7 +54,7 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
typedef std::map<content::WebContents*, UnsafeResourceList> UnsafeResourceMap;
// Interstitial type, used in tests.
- static const void* kTypeForTesting;
+ static content::InterstitialPageDelegate::TypeID kTypeForTesting;
~SafeBrowsingBlockingPage() override;
@@ -83,9 +84,7 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
void OnDontProceed() override;
void CommandReceived(const std::string& command) override;
void OverrideRendererPrefs(content::RendererPreferences* prefs) override;
-
- // SecurityInterstitialPage method:
- const void* GetTypeForTesting() const override;
+ content::InterstitialPageDelegate::TypeID GetTypeForTesting() const override;
protected:
friend class SafeBrowsingBlockingPageTest;
« no previous file with comments | « chrome/browser/interstitials/security_interstitial_page.h ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698