Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, telemetry-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Move TimeoutException from util module to exceptions module. This change helps move the Telemetry framework towards saner exception handling. BUG=460625 Committed: https://crrev.com/68c881e69be3e05f19783d6c5310ea43375d2383 Cr-Commit-Position: refs/heads/master@{#318349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -48 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/startup_metric.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/profile_creators/fast_navigation_profile_extender.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/forwarders/do_nothing_forwarder.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/forwarders/do_nothing_forwarder_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 2 chunks +3 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/util_unittest.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/web_contents.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/webpagereplay.py View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/tab_test_case.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/util/find_dependencies_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
erikchen
nednguyen: PTAL
5 years, 9 months ago (2015-02-26 01:55:55 UTC) #2
nednguyen
lgtm
5 years, 9 months ago (2015-02-26 01:57:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952693003/1
5 years, 9 months ago (2015-02-26 01:57:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45684)
5 years, 9 months ago (2015-02-26 02:39:01 UTC) #7
erikchen
kbr: Looking for an OWNER review of content/test/gpu/.
5 years, 9 months ago (2015-02-26 02:40:14 UTC) #9
Ken Russell (switch to Gerrit)
content/test/gpu lgtm
5 years, 9 months ago (2015-02-26 02:47:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952693003/1
5 years, 9 months ago (2015-02-26 18:25:47 UTC) #12
achuithb
On 2015/02/26 18:25:47, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-02-26 18:57:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45822)
5 years, 9 months ago (2015-02-26 18:57:25 UTC) #15
achuithb
FYI, this CL should land in a few hours: https://chromium-review.googlesource.com/#/c/254220/
5 years, 9 months ago (2015-02-26 19:19:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952693003/1
5 years, 9 months ago (2015-02-26 23:33:30 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 00:34:52 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 00:35:49 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/68c881e69be3e05f19783d6c5310ea43375d2383
Cr-Commit-Position: refs/heads/master@{#318349}

Powered by Google App Engine
This is Rietveld 408576698