tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index a5c14c33cba8e4ffcfd2c59486c89e7924c9eb5f..fef7479946e1c23c7a8b324e4fd5f6c6e9bc7a56 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -143,7 +143,7 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

else:

self.oobe.NavigateFakeLogin(self._username, self._password)

self._WaitForLogin()

- except util.TimeoutException:

+ except exceptions.TimeoutException:

self._cri.TakeScreenShot('login-screen')

raise exceptions.LoginException('Timed out going through login screen')