tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py - Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py

Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py ('k') | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py

index 93c2cc26e5872aea1131869494a5812bb8cfdeff..a56932425b81caec7c19629ed6436fec3af34365 100644

--- a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py

+++ b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

import logging

-from telemetry.core import util

+from telemetry.core import exceptions

class FormBasedCredentialsBackend(object):

@@ -111,7 +111,7 @@ class FormBasedCredentialsBackend(object):

self._logged_in = True

return True

- except util.TimeoutException:

+ except exceptions.TimeoutException:

logging.warning('Timed out while loading: %s', url)

return False