tools/perf/profile_creators/fast_navigation_profile_extender.py - Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/fast_navigation_profile_extender.py

Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/metrics/startup_metric.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/profile_creators/fast_navigation_profile_extender.py

diff --git a/tools/perf/profile_creators/fast_navigation_profile_extender.py b/tools/perf/profile_creators/fast_navigation_profile_extender.py

index d010cc7bdfd288dd2e05dd9243f3242f54f5c86b..e4904038b9fcd63e22d1aa8c14d8bff752849954 100644

--- a/tools/perf/profile_creators/fast_navigation_profile_extender.py

+++ b/tools/perf/profile_creators/fast_navigation_profile_extender.py

@@ -7,7 +7,6 @@ from telemetry.core import browser_finder

from telemetry.core import browser_finder_exceptions

from telemetry.core import exceptions

from telemetry.core import platform

-from telemetry.core import util

from telemetry.core.backends.chrome_inspector import devtools_http

@@ -240,7 +239,7 @@ class FastNavigationProfileExtender(object):

try:

tab.WaitForDocumentReadyStateToBeComplete(seconds_to_wait)

- except util.TimeoutException:

+ except exceptions.TimeoutException:

# Ignore time outs.

pass

except (exceptions.DevtoolsTargetCrashException,

« no previous file with comments | « tools/perf/metrics/startup_metric.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »