tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py - Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

Issue 952693003: Telemetry: Move TimeoutException from util module to exceptions module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

index 398ca86818f28e217e3290b147da1b07afe43ae5..75c884026eaee7770d279a2daac281a901299a52 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

@@ -8,6 +8,7 @@ import logging

import re

import urllib2

+from telemetry.core import exceptions

from telemetry.core import util

from telemetry.core.backends.chrome import chrome_browser_backend

from telemetry.core.backends.chrome import system_info_backend

@@ -90,7 +91,7 @@ class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

# Retry a few times since it can take a few seconds for this API to be

# ready, if ios_webkit_debug_proxy is just launched.

data = util.WaitFor(GetData, 5)

- except util.TimeoutException as e:

+ except exceptions.TimeoutException as e:

logging.debug('Timeout retrieving data from iOS device')

logging.debug(e)

return []