Merge back LayoutLayerModelObject into RenderBoxModelObject

Merge back LayoutLayerModelObject into RenderBoxModelObject

The class was added to share RenderLayer with SVG (see
https://bugs.webkit.org/show_bug.cgi?id=86022) with the
goal of having composited SVG but no progress was ever
made in this direction so it's better to revert back to
a more simple strategy. Also slimming paint should
change the way we composite and thus remove some deep
assumption about how we composite.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190713

[Julien - ping for review, 2015-02-20 18:39:36]

jchaffraix@chromium.org changed reviewers:
+ dsinclair@chromium.org, fmalita@chromium.org, leviw@chromium.org,
pdr@chromium.org

[Julien - ping for review, 2015-02-20 18:39:37]

Levi: For general rendering/ review.
Dan / Florin: FYI.
Philip: For web/ power (and rendering if you want to)!

[mstensho (USE GERRIT), 2015-02-20 18:50:28]

Welcome home / good riddance, LayoutLayerModelObject!

But why not move RenderBoxModelObject to LayoutBoxModelObject first, really?

[pdr., 2015-02-20 19:27:41]

LGTM 2! RIP svg layer dream.

[leviw_travelin_and_unemployed, 2015-02-20 19:28:54]

On 2015/02/20 at 18:50:28, mstensho wrote:
> Welcome home / good riddance, LayoutLayerModelObject!
> 
> But why not move RenderBoxModelObject to LayoutBoxModelObject first, really?

That seems like a better strategy to avoid double-renaming, but since we have a
patch I wouldn't block us from this path.

[f(malita), 2015-02-20 19:33:18]

Given the current state of affairs, LGTM++

*sniff*

[leviw_travelin_and_unemployed, 2015-02-20 19:37:02]

LGTM.

The SVG Layer dream is alive in the new hotness, Phil! Don't stop believin'!

https://codereview.chromium.org/945803004/diff/1/Source/core/layout/PaintInfo.h
File Source/core/layout/PaintInfo.h (right):

https://codereview.chromium.org/945803004/diff/1/Source/core/layout/PaintInfo...
Source/core/layout/PaintInfo.h:99: const RenderBoxModelObject* m_paintContainer;
// the layer object that originates the current painting
Update this comment?

[Julien - ping for review, 2015-02-23 23:56:55]

On 2015/02/20 at 19:28:54, leviw wrote:
> On 2015/02/20 at 18:50:28, mstensho wrote:
> > Welcome home / good riddance, LayoutLayerModelObject!
> > 
> > But why not move RenderBoxModelObject to LayoutBoxModelObject first, really?
> 
> That seems like a better strategy to avoid double-renaming, but since we have
a patch I wouldn't block us from this path.

This was done in https://codereview.chromium.org/944923004

[Julien - ping for review, 2015-02-23 23:57:16]

https://codereview.chromium.org/945803004/diff/1/Source/core/layout/PaintInfo.h
File Source/core/layout/PaintInfo.h (right):

https://codereview.chromium.org/945803004/diff/1/Source/core/layout/PaintInfo...
Source/core/layout/PaintInfo.h:99: const RenderBoxModelObject* m_paintContainer;
// the layer object that originates the current painting
On 2015/02/20 19:37:02, leviw wrote:
> Update this comment?

Done.

[Julien - ping for review, 2015-02-24 01:01:00]

The CQ bit was checked by jchaffraix@chromium.org

[Julien - ping for review, 2015-02-24 01:01:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
fmalita@chromium.org, leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/945803004/#ps40001 (title:
"Better rebasing.")

[commit-bot: I haz the power, 2015-02-24 01:01:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945803004/40001

[commit-bot: I haz the power, 2015-02-24 03:42:03]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190713