Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: Source/core/rendering/RenderBlock.cpp

Issue 945803004: Merge back LayoutLayerModelObject into RenderBoxModelObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Better rebasing. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/RenderBlockFlow.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 RenderBox::invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState); 365 RenderBox::invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState);
366 366
367 // Take care of positioned objects. This is required as PaintInvalidationSta te keeps a single clip rect. 367 // Take care of positioned objects. This is required as PaintInvalidationSta te keeps a single clip rect.
368 if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects( )) { 368 if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects( )) {
369 TrackedRendererListHashSet::iterator end = positionedObjects->end(); 369 TrackedRendererListHashSet::iterator end = positionedObjects->end();
370 for (TrackedRendererListHashSet::iterator it = positionedObjects->begin( ); it != end; ++it) { 370 for (TrackedRendererListHashSet::iterator it = positionedObjects->begin( ); it != end; ++it) {
371 RenderBox* box = *it; 371 RenderBox* box = *it;
372 372
373 // One of the renderers we're skipping over here may be the child's paint invalidation container, 373 // One of the renderers we're skipping over here may be the child's paint invalidation container,
374 // so we can't pass our own paint invalidation container along. 374 // so we can't pass our own paint invalidation container along.
375 const LayoutLayerModelObject& paintInvalidationContainerForChild = * box->containerForPaintInvalidation(); 375 const LayoutBoxModelObject& paintInvalidationContainerForChild = *bo x->containerForPaintInvalidation();
376 376
377 // If it's a new paint invalidation container, we won't have properl y accumulated the offset into the 377 // If it's a new paint invalidation container, we won't have properl y accumulated the offset into the
378 // PaintInvalidationState. 378 // PaintInvalidationState.
379 // FIXME: Teach PaintInvalidationState to handle this case. crbug.co m/371485 379 // FIXME: Teach PaintInvalidationState to handle this case. crbug.co m/371485
380 if (paintInvalidationContainerForChild != childPaintInvalidationStat e.paintInvalidationContainer()) { 380 if (paintInvalidationContainerForChild != childPaintInvalidationStat e.paintInvalidationContainer()) {
381 ForceHorriblySlowRectMapping slowRectMapping(&childPaintInvalida tionState); 381 ForceHorriblySlowRectMapping slowRectMapping(&childPaintInvalida tionState);
382 PaintInvalidationState disabledPaintInvalidationState(childPaint InvalidationState, *this, paintInvalidationContainerForChild); 382 PaintInvalidationState disabledPaintInvalidationState(childPaint InvalidationState, *this, paintInvalidationContainerForChild);
383 box->invalidateTreeIfNeeded(disabledPaintInvalidationState); 383 box->invalidateTreeIfNeeded(disabledPaintInvalidationState);
384 continue; 384 continue;
385 } 385 }
(...skipping 3085 matching lines...) Expand 10 before | Expand all | Expand 10 after
3471 // https://bugs.webkit.org/show_bug.cgi?id=46781 3471 // https://bugs.webkit.org/show_bug.cgi?id=46781
3472 LayoutRect localRect(LayoutPoint(), size()); 3472 LayoutRect localRect(LayoutPoint(), size());
3473 localRect.expand(collapsedMarginBoxLogicalOutsets()); 3473 localRect.expand(collapsedMarginBoxLogicalOutsets());
3474 quads.append(localToAbsoluteQuad(FloatRect(localRect), 0 /* mode */, was Fixed)); 3474 quads.append(localToAbsoluteQuad(FloatRect(localRect), 0 /* mode */, was Fixed));
3475 continuation()->absoluteQuads(quads, wasFixed); 3475 continuation()->absoluteQuads(quads, wasFixed);
3476 } else { 3476 } else {
3477 quads.append(RenderBox::localToAbsoluteQuad(FloatRect(0, 0, size().width ().toFloat(), size().height().toFloat()), 0 /* mode */, wasFixed)); 3477 quads.append(RenderBox::localToAbsoluteQuad(FloatRect(0, 0, size().width ().toFloat(), size().height().toFloat()), 0 /* mode */, wasFixed));
3478 } 3478 }
3479 } 3479 }
3480 3480
3481 LayoutRect RenderBlock::rectWithOutlineForPaintInvalidation(const LayoutLayerMod elObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvali dationState* paintInvalidationState) const 3481 LayoutRect RenderBlock::rectWithOutlineForPaintInvalidation(const LayoutBoxModel Object* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalida tionState* paintInvalidationState) const
3482 { 3482 {
3483 LayoutRect r(RenderBox::rectWithOutlineForPaintInvalidation(paintInvalidatio nContainer, outlineWidth, paintInvalidationState)); 3483 LayoutRect r(RenderBox::rectWithOutlineForPaintInvalidation(paintInvalidatio nContainer, outlineWidth, paintInvalidationState));
3484 if (isAnonymousBlockContinuation()) 3484 if (isAnonymousBlockContinuation())
3485 r.inflateY(collapsedMarginBefore()); // FIXME: This is wrong for vertica l writing-modes. 3485 r.inflateY(collapsedMarginBefore()); // FIXME: This is wrong for vertica l writing-modes.
3486 return r; 3486 return r;
3487 } 3487 }
3488 3488
3489 LayoutObject* RenderBlock::hoverAncestor() const 3489 LayoutObject* RenderBlock::hoverAncestor() const
3490 { 3490 {
3491 return isAnonymousBlockContinuation() ? continuation() : RenderBox::hoverAnc estor(); 3491 return isAnonymousBlockContinuation() ? continuation() : RenderBox::hoverAnc estor();
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
3945 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Layout Object* obj) const 3945 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Layout Object* obj) const
3946 { 3946 {
3947 showLayoutObject(); 3947 showLayoutObject();
3948 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 3948 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
3949 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 3949 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
3950 } 3950 }
3951 3951
3952 #endif 3952 #endif
3953 3953
3954 } // namespace blink 3954 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/RenderBlockFlow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698