Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 944923004: rendering/RenderBoxModelObject -> layout/LayoutBoxModelObject (Closed)

Created:
5 years, 10 months ago by Julien - ping for review
Modified:
5 years, 10 months ago
CC:
aandrey+blink_chromium.org, aboxhall, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, Rik, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, Dominik Röttsches, dshwang, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, eustas+blink_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, je_julie(Not used), Justin Novosad, kenneth.christiansen, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, slimming-paint-reviews_chromium.org, Steve Block, Timothy Loh, yurys+blink_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

rendering/RenderBoxModelObject -> layout/LayoutBoxModelObject Straightforward migration of rendering/RenderBoxModelObject. BUG=450612 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -1151 lines) Patch
M LayoutTests/fullscreen/full-screen-crash-offsetLeft.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/full-screen-crash-offsetLeft-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/HitRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/layout/Layer.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/layout/LayoutBoxModelObject.h View 6 chunks +17 lines, -17 lines 0 comments Download
A + Source/core/layout/LayoutBoxModelObject.cpp View 23 chunks +45 lines, -43 lines 0 comments Download
M Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BoxDecorationData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/BoxPainter.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/LineBoxListPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/LineBoxListPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 25 chunks +28 lines, -28 lines 0 comments Download
D Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -223 lines 0 comments Download
D Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -663 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 20 chunks +29 lines, -29 lines 0 comments Download
M Source/core/rendering/RenderLineBoxList.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderLineBoxList.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXRenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 12 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/accessibility/AXTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Julien - ping for review
Super trivial migration as requested on https://codereview.chromium.org/945803004 Morten: FYI (or for rendering/ if you are ...
5 years, 10 months ago (2015-02-20 23:28:09 UTC) #2
pdr.
On 2015/02/20 at 23:28:09, jchaffraix wrote: > Super trivial migration as requested on https://codereview.chromium.org/945803004 > ...
5 years, 10 months ago (2015-02-20 23:42:20 UTC) #3
leviw_travelin_and_unemployed
LGTM2.
5 years, 10 months ago (2015-02-20 23:58:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944923004/1
5 years, 10 months ago (2015-02-23 16:30:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 16:33:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190666

Powered by Google App Engine
This is Rietveld 408576698