Telemetry: Removed unused code from InspectorWebsocket.

Telemetry: Removed unused code from InspectorWebsocket.

The will_close_handler parameter of RegisterDomain is never used.

Committed: https://crrev.com/5b1c7e5f61e29eaca5e40be542f82d048b667918
Cr-Commit-Position: refs/heads/master@{#317640}

[erikchen, 2015-02-21 00:44:10]

Patchset #1 (id:1) has been deleted

[erikchen, 2015-02-21 00:44:21]

erikchen@chromium.org changed reviewers:
+ nednguyen@google.com

[erikchen, 2015-02-21 00:44:21]

nednguyen: Please review.

[nednguyen, 2015-02-21 06:07:48]

lgtm

Thanks for the cleanup!

https://codereview.chromium.org/945193002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py
(right):

https://codereview.chromium.org/945193002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py:69:
del self._domain_handlers[domain_name]
What is this change for?

[erikchen, 2015-02-23 18:27:56]

https://codereview.chromium.org/945193002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py
(right):

https://codereview.chromium.org/945193002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py:69:
del self._domain_handlers[domain_name]
On 2015/02/21 06:07:48, nednguyen wrote:
> What is this change for?

Pop has a return value, whereas del does not. Since the return value isn't used,
it makes more sense to use del.

[erikchen, 2015-02-23 18:27:59]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-23 18:28:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945193002/20001

[commit-bot: I haz the power, 2015-02-23 18:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 18:31:46]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[erikchen, 2015-02-23 20:24:05]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-23 20:24:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945193002/20001

[commit-bot: I haz the power, 2015-02-23 20:25:10]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-02-23 20:25:46]

Patchset 1 (id:??) landed as
https://crrev.com/5b1c7e5f61e29eaca5e40be542f82d048b667918
Cr-Commit-Position: refs/heads/master@{#317640}