tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py - Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py » ('j') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

index 05b95bdd1831e6d41d4d686c6ff17c004c7ff7c0..0a52996da00eeacbc289476312d9a94edb1f64e1 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

@@ -211,10 +211,7 @@ class InspectorBackend(object):

if res['method'] == 'HeapProfiler.addHeapSnapshotChunk':

snapshot.append(res['params']['chunk'])

- def OnClose():

- pass

- self._websocket.RegisterDomain('HeapProfiler', OnNotification, OnClose)

+ self._websocket.RegisterDomain('HeapProfiler', OnNotification)

self._websocket.SyncRequest({'method': 'Page.getResourceTree'}, timeout)

self._websocket.SyncRequest({'method': 'Debugger.enable'}, timeout)