tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py - Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py ('k') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_runtime.py » ('j') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

index be9a21b00a00b2cff37a6793ce0cbe3a96c89ceb..aa682fe39af86ff5f569854a444d6fba632b3598 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

@@ -11,10 +11,7 @@ from telemetry.image_processing import image_util

class InspectorPage(object):

def __init__(self, inspector_websocket, timeout=60):

self._inspector_websocket = inspector_websocket

- self._inspector_websocket.RegisterDomain(

- 'Page',

- self._OnNotification,

- self._OnClose)

+ self._inspector_websocket.RegisterDomain('Page', self._OnNotification)

self._navigation_pending = False

self._navigation_url = '' # Support for legacy backends.

@@ -45,9 +42,6 @@ class InspectorPage(object):

# WaitForNavigate call.

self._navigation_pending = False

- def _OnClose(self):

- pass

def _SetScriptToEvaluateOnCommit(self, source):

existing_source = (self._script_to_evaluate_on_commit and

self._script_to_evaluate_on_commit['source'])