tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py - Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py

Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py » ('j') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py

index 19f4ea21b32118ae3ac8f8fe06a44945a879fe0c..ebd8aef10952bfd002d8e0b09d45827e743dc239 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_console.py

@@ -6,10 +6,7 @@

class InspectorConsole(object):

def __init__(self, inspector_websocket):

self._inspector_websocket = inspector_websocket

- self._inspector_websocket.RegisterDomain(

- 'Console',

- self._OnNotification,

- self._OnClose)

+ self._inspector_websocket.RegisterDomain('Console', self._OnNotification)

self._message_output_stream = None

self._last_message = None

self._console_enabled = False

@@ -31,9 +28,6 @@ class InspectorConsole(object):

self._message_output_stream.write(

'%s\n' % self._last_message)

- def _OnClose(self):

- pass

# False positive in PyLint 0.25.1: http://www.logilab.org/89092

@property

def message_output_stream(self): # pylint: disable=E0202