tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py - Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py

Issue 945193002: Telemetry: Removed unused code from InspectorWebsocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py ('k') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py » ('j') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py

index 5b7b3e8bea2fedf1d2eac1cb173024b976c4d41a..9dfaa1b9b87e063a01f6dea212ad44076d293990 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py

@@ -143,8 +143,7 @@ class InspectorNetwork(object):

self.ClearResponseData()

self._inspector_websocket.RegisterDomain(

'Network',

- self._OnNetworkNotification,

- self._OnClose)

+ self._OnNetworkNotification)

request = {

'method': 'Network.enable'

}

@@ -199,9 +198,6 @@ class InspectorNetwork(object):

def HTTPResponseServedFromCache(self, request_id):

return request_id and request_id in self._served_from_cache

- def _OnClose(self):

- pass

@property

def timeline_recorder(self):

if not self._timeline_recorder: