Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 942583002: Move rendering/RenderProgress to layout/LayoutProgress (Closed)

Created:
5 years, 10 months ago by dsinclair
Modified:
5 years, 10 months ago
CC:
aboxhall, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, dmazzoni, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, je_julie(Not used), leviw+renderwatch, nektarios, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -300 lines) Patch
M LayoutTests/fast/dom/HTMLProgressElement/progress-element-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt View 7 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt View 7 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt View 7 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt View 7 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLProgressElement/progress-element-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/layout/LayoutProgress.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/layout/LayoutProgress.cpp View 5 chunks +14 lines, -13 lines 0 comments Download
M Source/core/layout/LayoutTheme.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTheme.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutThemeAndroid.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeDefault.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutThemeDefault.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
D Source/core/rendering/RenderProgress.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/rendering/RenderProgress.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXProgressIndicator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXProgressIndicator.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942583002/1
5 years, 10 months ago (2015-02-19 19:33:17 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 10 months ago (2015-02-19 22:32:50 UTC) #5
jbroman
lgtm https://codereview.chromium.org/942583002/diff/20001/Source/core/html/HTMLProgressElement.cpp File Source/core/html/HTMLProgressElement.cpp (right): https://codereview.chromium.org/942583002/diff/20001/Source/core/html/HTMLProgressElement.cpp#newcode68 Source/core/html/HTMLProgressElement.cpp:68: LayoutProgress* HTMLProgressElement::renderProgress() const rename this?
5 years, 10 months ago (2015-02-23 14:51:14 UTC) #8
dsinclair
On 2015/02/23 at 14:51:14, jbroman wrote: > lgtm > > https://codereview.chromium.org/942583002/diff/20001/Source/core/html/HTMLProgressElement.cpp > File Source/core/html/HTMLProgressElement.cpp (right): ...
5 years, 10 months ago (2015-02-23 15:00:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942583002/40001
5 years, 10 months ago (2015-02-23 15:01:29 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 16:29:59 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190665

Powered by Google App Engine
This is Rietveld 408576698