Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939093002: Recycle stencil buffers across render targets. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@keychange
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Recycle stencil buffers across render targets. Committed: https://skia.googlesource.com/skia/+/02a44a488605112aa6683c9d919e13b188112ce1

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : minor #

Total comments: 4

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -35 lines) Patch
M src/gpu/GrGpu.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/GrStencilBuffer.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/GrStencilBuffer.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 3 chunks +1 line, -7 lines 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 2 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 10 months ago (2015-02-19 15:31:34 UTC) #2
robertphillips
lgtm + minor questions https://codereview.chromium.org/939093002/diff/60001/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/939093002/diff/60001/src/gpu/gl/GrGLGpu.cpp#newcode444 src/gpu/gl/GrGLGpu.cpp:444: GrGLStencilBuffer::IDDesc sbDesc; Is this next ...
5 years, 10 months ago (2015-02-19 16:39:26 UTC) #3
bsalomon
https://codereview.chromium.org/939093002/diff/60001/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/939093002/diff/60001/src/gpu/gl/GrGLGpu.cpp#newcode444 src/gpu/gl/GrGLGpu.cpp:444: GrGLStencilBuffer::IDDesc sbDesc; On 2015/02/19 16:39:26, robertphillips wrote: > Is ...
5 years, 10 months ago (2015-02-19 16:54:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939093002/80001
5 years, 10 months ago (2015-02-19 16:55:44 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 17:09:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/02a44a488605112aa6683c9d919e13b188112ce1

Powered by Google App Engine
This is Rietveld 408576698