Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 93863005: ui: Rename ui_export.h to ui_base_export.h (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, yusukes+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, derat+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, sadrul, dcheng, James Su, stevenjb+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

ui: Rename ui_export.h to ui_base_export.h Also renames UI_EXPORT to UI_BASE_EXPORT. BUG=299841 TEST=None, no functional changes TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243050

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : UI_BASE_IMPLEMENTATION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+778 lines, -753 lines) Patch
M ui/base/accelerators/accelerator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/accelerators/accelerator_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/accelerators/menu_label_accelerator_util_linux.h View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/base/accelerators/platform_accelerator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/accelerators/platform_accelerator_cocoa.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/platform_accelerator_gtk.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/base/accessibility/accessible_text_utils.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M ui/base/accessibility/accessible_view_state.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/android/ui_base_jni_registrar.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/android/view_android.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/android/window_android.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/android/window_android_observer.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/base_window.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_util_win.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 2 chunks +12 lines, -12 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/appkit_utils.h View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M ui/base/cocoa/base_view.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/cocoa/cocoa_event_utils.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/base/cocoa/controls/blue_label_button.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hover_image_menu_button.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hover_image_menu_button_cell.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hyperlink_button_cell.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/find_pasteboard.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/cocoa/flipped_view.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/focus_tracker.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/focus_window_set.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/fullscreen_window_manager.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/hover_button.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/hover_image_button.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/menu_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/nib_loading.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/tracking_area.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/underlay_opengl_hosting_window.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/window_size_constants.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cursor/cursor.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cursor/cursor_loader.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cursor/cursor_loader_null.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cursor/cursor_loader_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursor_loader_x11.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cursor/cursors_aura.h View 1 2 2 chunks +13 lines, -14 lines 0 comments Download
M ui/base/default_theme_provider.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/device_form_factor.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/cocoa_dnd_util.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M ui/base/dragdrop/download_file_interface.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/drag_drop_types.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/drag_source_win.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/drag_utils.h View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M ui/base/dragdrop/drop_target_event.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/drop_target_win.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/gtk_dnd_util.h View 3 chunks +18 lines, -19 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.h View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/gtk/event_synthesis_gtk.h View 1 2 3 4 5 1 chunk +11 lines, -10 lines 0 comments Download
M ui/base/gtk/focus_store_gtk.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/gtk/g_object_destructor_filo.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/gtk/gtk_expanded_container.h View 1 2 3 4 5 2 chunks +13 lines, -9 lines 0 comments Download
M ui/base/gtk/gtk_floating_container.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/gtk/gtk_screen_util.h View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
M ui/base/gtk/gtk_signal_registrar.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/gtk/gtk_windowing.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/gtk/owned_widget_gtk.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/gtk/scoped_region.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/character_composer.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/ibus_bridge.h View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_candidate_window_handler.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_input_context_handler.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/composition_text.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/composition_text_util_pango.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/dummy_input_method_delegate.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_base.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_delegate.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_factory.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_ibus.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_imm32.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_initializer.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/ime/input_method_minimal.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_observer.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_tsf.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_win.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/linux/linux_input_method_context.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/linux/linux_input_method_context_factory.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/mock_input_method.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/remote_input_method_delegate_win.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/remote_input_method_win.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/text_input_client.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/win/imm32_manager.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/win/tsf_bridge.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/win/tsf_event_router.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/win/tsf_input_scope.h View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
M ui/base/ime/win/tsf_text_store.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/l10n/l10n_font_util.h View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M ui/base/l10n/l10n_util.h View 4 chunks +69 lines, -66 lines 0 comments Download
M ui/base/l10n/l10n_util_android.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/l10n/l10n_util_collator.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_mac.h View 2 chunks +37 lines, -38 lines 0 comments Download
M ui/base/l10n/l10n_util_win.h View 4 chunks +11 lines, -10 lines 0 comments Download
M ui/base/l10n/time_format.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/layout.h View 3 chunks +10 lines, -10 lines 0 comments Download
M ui/base/models/button_menu_item_model.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/models/combobox_model.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/combobox_model_observer.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/dialog_model.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/list_model_observer.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/list_selection_model.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/models/menu_model.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/table_model.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/models/table_model_observer.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/tree_model.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/resource/data_pack.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_win.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_handle.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/text/bytes_formatting.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ui/base/theme_provider.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/touch/touch_device.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/touch/touch_enabled.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A ui/base/ui_base_export.h View 1 2 3 4 5 6 7 1 chunk +37 lines, -0 lines 0 comments Download
M ui/base/ui_base_paths.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +18 lines, -18 lines 0 comments Download
M ui/base/ui_base_switches_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/ui_base_types.h View 2 chunks +2 lines, -2 lines 0 comments Download
D ui/base/ui_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/base/view_prop.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/webui/jstemplate_builder.h View 3 chunks +21 lines, -18 lines 0 comments Download
M ui/base/webui/web_ui_util.h View 3 chunks +11 lines, -12 lines 0 comments Download
M ui/base/win/accessibility_misc_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/dpi_setup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/foreground_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/hidden_window.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/hwnd_subclass.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/win/message_box_win.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/base/win/mouse_wheel_util.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M ui/base/win/scoped_ole_initializer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/shell.h View 4 chunks +15 lines, -13 lines 0 comments Download
M ui/base/win/touch_input.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/win/touch_input.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/window_open_disposition.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/base/work_area_watcher_observer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/x/active_window_watcher_x.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/active_window_watcher_x_observer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/x/selection_owner.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/selection_requestor.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/selection_utils.h View 3 chunks +11 lines, -9 lines 0 comments Download
M ui/base/x/work_area_watcher_x.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/x11_util.h View 12 chunks +89 lines, -88 lines 0 comments Download
M ui/base/x/x11_util_internal.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/ui.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
TBRing...
6 years, 11 months ago (2014-01-05 21:02:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/93863005/140001
6 years, 11 months ago (2014-01-05 21:07:03 UTC) #2
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=104292
6 years, 11 months ago (2014-01-05 22:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/93863005/530001
6 years, 11 months ago (2014-01-05 22:37:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241729
6 years, 11 months ago (2014-01-06 00:45:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/93863005/530001
6 years, 11 months ago (2014-01-06 00:50:37 UTC) #6
commit-bot: I haz the power
Change committed as 243050
6 years, 11 months ago (2014-01-06 02:05:45 UTC) #7
Ben Goodger (Google)
6 years, 11 months ago (2014-01-06 17:46:58 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698