Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: content/public/browser/navigator_connect_service_factory.h

Issue 938403005: Make it possible for a navigator.connect service to receive messages as base::Value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-pass-flag
Patch Set: mention bug Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_shell.gypi ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigator_connect_service_factory.h
diff --git a/content/public/browser/navigator_connect_service_factory.h b/content/public/browser/navigator_connect_service_factory.h
index f66b2de18524142863df79dd359bb04bacf48de4..4a71f27b80133114c245afda557e86ff81389711 100644
--- a/content/public/browser/navigator_connect_service_factory.h
+++ b/content/public/browser/navigator_connect_service_factory.h
@@ -24,7 +24,11 @@ class NavigatorConnectServiceFactory {
// remains with the factory. It is assumed that for the passed
// MessagePortDelegate implementation the route_id and message_port_id of a
// connection are the same.
- using ConnectCallback = base::Callback<void(MessagePortDelegate*)>;
+ // Pass true to |data_as_values| if the delegate expects to receive messages
+ // from the client encoded as base::Value instead of the normal serialization
+ // format.
+ using ConnectCallback =
+ base::Callback<void(MessagePortDelegate*, bool data_as_values)>;
virtual ~NavigatorConnectServiceFactory() {}
« no previous file with comments | « content/content_shell.gypi ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698