Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc

Issue 938403005: Make it possible for a navigator.connect service to receive messages as base::Value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-message-as-values-pass-flag
Patch Set: mention bug Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/navigator_connect/navigator_connect_context_impl.cc ('k') | content/content_shell.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc
diff --git a/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc b/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc
index 30daf4999e122f7a5c61a3e08cdb0e936cde56fd..331c858f90b9a8bb5b6f75b6b31af09547bbf82f 100644
--- a/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc
+++ b/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc
@@ -185,14 +185,17 @@ void NavigatorConnectServiceWorkerServiceFactory::OnConnectResult(
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (status != SERVICE_WORKER_OK || !accept_connection) {
- callback.Run(nullptr);
+ callback.Run(nullptr, false);
return;
}
- // TODO(mek): Keep track of NavigatorConnectServiceWorkerService instances and
- // clean them up when a service worker registration is deleted.
- callback.Run(new NavigatorConnectServiceWorkerService(
- service_worker_context_, client, service_worker_registration));
+ // TODO(mek): http://crbug.com/462744 Keep track of these
+ // NavigatorConnectServiceWorkerService instances and clean them up when a
+ // service worker registration is deleted.
+ callback.Run(
+ new NavigatorConnectServiceWorkerService(service_worker_context_, client,
+ service_worker_registration),
+ false);
}
} // namespace content
« no previous file with comments | « content/browser/navigator_connect/navigator_connect_context_impl.cc ('k') | content/content_shell.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698