Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 920863002: A simple change to move a bunch of stuff out of Gr*Geometry.h (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

A simple change to move a bunch of stuff out of Gr*Geometry.h BUG=skia: Committed: https://skia.googlesource.com/skia/+/8072caa80384292858d31ae34b7e19768875866b

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : clang fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+734 lines, -1258 lines) Patch
M gyp/gpu.gypi View 4 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 2 chunks +1 line, -263 lines 0 comments Download
M src/gpu/GrGeometryProcessor.cpp View 2 chunks +0 lines, -542 lines 0 comments Download
A src/gpu/GrPathProcessor.h View 1 chunk +65 lines, -0 lines 0 comments Download
A src/gpu/GrPathProcessor.cpp View 1 chunk +73 lines, -0 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
A + src/gpu/GrPrimitiveProcessor.h View 2 chunks +2 lines, -190 lines 0 comments Download
A src/gpu/GrPrimitiveProcessor.cpp View 1 chunk +67 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 2 chunks +2 lines, -154 lines 0 comments Download
A src/gpu/gl/GrGLGeometryProcessor.cpp View 1 1 chunk +129 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLPathProcessor.h View 1 chunk +113 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLPathProcessor.cpp View 1 2 1 chunk +183 lines, -0 lines 0 comments Download
A + src/gpu/gl/GrGLPrimitiveProcessor.h View 3 chunks +5 lines, -103 lines 0 comments Download
A src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 chunk +75 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
just moving code out of files
5 years, 10 months ago (2015-02-12 21:43:07 UTC) #3
bsalomon
lgtm
5 years, 10 months ago (2015-02-12 21:48:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920863002/1
5 years, 10 months ago (2015-02-12 21:49:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2023)
5 years, 10 months ago (2015-02-12 21:51:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920863002/40001
5 years, 10 months ago (2015-02-12 22:13:25 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 22:20:56 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8072caa80384292858d31ae34b7e19768875866b

Powered by Google App Engine
This is Rietveld 408576698