Make WebGL2 objects Oilpan compatible.

Make WebGL2 objects Oilpan compatible.

Follow up r189868 by rounding out its Oilpan support.

R=haraken
BUG=295792
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189881

[sof, 2015-02-10 08:17:21]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-02-10 08:17:22]

Please take a look.

[haraken, 2015-02-10 08:44:50]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-02-10 08:44:51]

LGTM

https://codereview.chromium.org/913603003/diff/1/Source/core/html/canvas/WebG...
File Source/core/html/canvas/WebGLQuery.cpp (right):

https://codereview.chromium.org/913603003/diff/1/Source/core/html/canvas/WebG...
Source/core/html/canvas/WebGLQuery.cpp:27: detachAndDeleteObject();

Just help me understand: Why is deleteObject(0) enough in non-oilpan but not
enough in oilpan? I'm curious about where the difference comes from.

[sof, 2015-02-10 08:50:50]

https://codereview.chromium.org/913603003/diff/1/Source/core/html/canvas/WebG...
File Source/core/html/canvas/WebGLQuery.cpp (right):

https://codereview.chromium.org/913603003/diff/1/Source/core/html/canvas/WebG...
Source/core/html/canvas/WebGLQuery.cpp:27: detachAndDeleteObject();
On 2015/02/10 08:44:51, haraken wrote:
> 
> Just help me understand: Why is deleteObject(0) enough in non-oilpan but not
> enough in oilpan? I'm curious about where the difference comes from.

Did you read the above comment and look up the ~WebGLBuffer comment?

[haraken, 2015-02-10 08:55:33]

https://codereview.chromium.org/913603003/diff/1/Source/core/html/canvas/WebG...
File Source/core/html/canvas/WebGLQuery.cpp (right):

https://codereview.chromium.org/913603003/diff/1/Source/core/html/canvas/WebG...
Source/core/html/canvas/WebGLQuery.cpp:27: detachAndDeleteObject();
On 2015/02/10 08:50:50, sof wrote:
> On 2015/02/10 08:44:51, haraken wrote:
> > 
> > Just help me understand: Why is deleteObject(0) enough in non-oilpan but not
> > enough in oilpan? I'm curious about where the difference comes from.
> 
> Did you read the above comment and look up the ~WebGLBuffer comment?

Thanks, got it!

[sof, 2015-02-10 09:08:36]

(Waiting on oilpan bot results, will land asap after that.)

[sof, 2015-02-10 09:49:12]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-02-10 09:50:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/913603003/1

[commit-bot: I haz the power, 2015-02-10 09:53:41]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189881

[Ken Russell (switch to Gerrit), 2015-02-10 13:53:29]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-02-10 13:53:30]

Thanks for this cleanup. Sorry for missing these issues in the original code
review.

[bajones, 2015-02-10 16:08:37]

post-commit LGTM.

Thanks for fixing this! I apologize for letting it slip my mind and not getting
an Oilpan review on the previous CL before landing.

[sof, 2015-02-10 16:24:00]

On 2015/02/10 16:08:37, bajones wrote:
> post-commit LGTM.
> 
> Thanks for fixing this! I apologize for letting it slip my mind and not
getting
> an Oilpan review on the previous CL before landing.

No worries whatsoever. On closer look, your CL had done a lot of things right
wrt Oilpan, so this just rounded it out.

But if you've only got the slightest suspicion of a change having an impact on
Oilpan, don't hesitate to Cc: oilpan-reviews. Happy to help out & at least
prepare for oncoming changes. (Until CQ gets involved, build breakages are our
problems to address entirely.)