Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: Source/core/html/canvas/WebGLQuery.cpp

Issue 913603003: Make WebGL2 objects Oilpan compatible. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include "core/html/canvas/WebGLQuery.h" 7 #include "core/html/canvas/WebGLQuery.h"
8 8
9 #include "core/html/canvas/WebGL2RenderingContextBase.h" 9 #include "core/html/canvas/WebGL2RenderingContextBase.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 PassRefPtrWillBeRawPtr<WebGLQuery> WebGLQuery::create(WebGL2RenderingContextBase * ctx) 13 PassRefPtrWillBeRawPtr<WebGLQuery> WebGLQuery::create(WebGL2RenderingContextBase * ctx)
14 { 14 {
15 return adoptRefWillBeNoop(new WebGLQuery(ctx)); 15 return adoptRefWillBeNoop(new WebGLQuery(ctx));
16 } 16 }
17 17
18 WebGLQuery::~WebGLQuery() 18 WebGLQuery::~WebGLQuery()
19 { 19 {
20 deleteObject(0); 20 // Always call detach here to ensure that platform object deletion
21 // happens with Oilpan enabled. It keeps the code regular to do it
22 // with or without Oilpan enabled.
23 //
24 // See comment in WebGLBuffer's destructor for additional
25 // information on why this is done for WebGLSharedObject-derived
26 // objects.
27 detachAndDeleteObject();
haraken 2015/02/10 08:44:51 Just help me understand: Why is deleteObject(0) en
sof 2015/02/10 08:50:50 Did you read the above comment and look up the ~We
haraken 2015/02/10 08:55:33 Thanks, got it!
21 } 28 }
22 29
23 WebGLQuery::WebGLQuery(WebGL2RenderingContextBase* ctx) 30 WebGLQuery::WebGLQuery(WebGL2RenderingContextBase* ctx)
24 : WebGLSharedObject(ctx) 31 : WebGLSharedObject(ctx)
25 { 32 {
26 setObject(ctx->webContext()->createQueryEXT()); 33 setObject(ctx->webContext()->createQueryEXT());
27 } 34 }
28 35
29 void WebGLQuery::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Platfo rm3DObject object) 36 void WebGLQuery::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Platfo rm3DObject object)
30 { 37 {
31 context3d->deleteQueryEXT(object); 38 context3d->deleteQueryEXT(object);
32 } 39 }
33 40
34 } // namespace blink 41 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('k') | Source/core/html/canvas/WebGLSampler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698