Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: Source/core/html/canvas/WebGLQuery.cpp

Issue 913603003: Make WebGL2 objects Oilpan compatible. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('k') | Source/core/html/canvas/WebGLSampler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/canvas/WebGLQuery.cpp
diff --git a/Source/core/html/canvas/WebGLQuery.cpp b/Source/core/html/canvas/WebGLQuery.cpp
index eebca4ed1f02b0818a835561665be82296613936..f62268e7a63361359b0e1e0d02f4832091fe3a5c 100644
--- a/Source/core/html/canvas/WebGLQuery.cpp
+++ b/Source/core/html/canvas/WebGLQuery.cpp
@@ -17,7 +17,14 @@ PassRefPtrWillBeRawPtr<WebGLQuery> WebGLQuery::create(WebGL2RenderingContextBase
WebGLQuery::~WebGLQuery()
{
- deleteObject(0);
+ // Always call detach here to ensure that platform object deletion
+ // happens with Oilpan enabled. It keeps the code regular to do it
+ // with or without Oilpan enabled.
+ //
+ // See comment in WebGLBuffer's destructor for additional
+ // information on why this is done for WebGLSharedObject-derived
+ // objects.
+ detachAndDeleteObject();
haraken 2015/02/10 08:44:51 Just help me understand: Why is deleteObject(0) en
sof 2015/02/10 08:50:50 Did you read the above comment and look up the ~We
haraken 2015/02/10 08:55:33 Thanks, got it!
}
WebGLQuery::WebGLQuery(WebGL2RenderingContextBase* ctx)
« no previous file with comments | « Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('k') | Source/core/html/canvas/WebGLSampler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698