Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly.

Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. (Closed)

Created:
7 years ago by yoichio

Modified:
7 years ago

Reviewers:
Hiro Komatsu, Matt Perry, not at google - send to devlin

CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. Remove unsued arguments from the constructor. This doesn't change the actual behavior. BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238345

Patch Set 1 #

Patch Set 2 : Add OWNER file #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -61 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_engine.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine.cc	View		1 chunk	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
A +	chrome/browser/extensions/api/input_ime/OWNERS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/input_ime/input_ime_api.cc	View		3 chunks	+6 lines, -14 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/90933002/1

7 years ago (2013-11-27 08:27:26 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=38331

7 years ago (2013-11-27 08:43:07 UTC) #4

yoichio

Add mpcomplete@ as input_ime_api.cc extensions OWNER. Could you take a look?

7 years ago (2013-11-27 09:19:18 UTC) #5

yoichio

Matt looks ooo, so I add kalman@ as another OWNER of extensions/api/input_ime/input_ime_api.cc. Could you look ...

7 years ago (2013-11-28 00:28:19 UTC) #6

not at google - send to devlin

lgtm. You might want to add an OWNERS file in the input_ime directory in this ...

7 years ago (2013-12-02 23:20:08 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/90933002/1

7 years ago (2013-12-02 23:46:57 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/90933002/20001

7 years ago (2013-12-03 01:12:17 UTC) #10

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=230958

7 years ago (2013-12-03 06:13:39 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/90933002/20001

7 years ago (2013-12-03 08:07:56 UTC) #12

Message was sent while issue was closed.

Change committed as 238345

Expand Messages | Collapse Messages