chrome/browser/chromeos/input_method/input_method_engine_ibus.h - Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_ibus.h

Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add OWNER file Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chrome/browser/chromeos/input_method/input_method_engine_ibus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_ibus.h

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_ibus.h b/chrome/browser/chromeos/input_method/input_method_engine_ibus.h

index 8a22a1c9016e6dd1335e3f033b0c456c9dba727f..d79476e982d66f611bcffa752adf4685aa257445 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_ibus.h

+++ b/chrome/browser/chromeos/input_method/input_method_engine_ibus.h

@@ -38,12 +38,10 @@ class InputMethodEngineIBus : public InputMethodEngine,

const char* engine_name,

const char* extension_id,

const char* engine_id,

- const char* description,

const std::vector<std::string>& languages,

const std::vector<std::string>& layouts,

const GURL& options_page,

- const GURL& input_view,

- std::string* error);

+ const GURL& input_view);

// InputMethodEngine overrides.

virtual void StartIme() OVERRIDE;