chrome/browser/chromeos/input_method/input_method_engine_ibus.cc - Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_ibus.cc

Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add OWNER file Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_ibus.h ('k') | chrome/browser/extensions/api/input_ime/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_ibus.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc b/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc

index c485a6c5f02c81f38f5acbd028dda70242562ed2..e4a3fc63128a89c3d8d01988697ea7108fb4af2c 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc

@@ -86,12 +86,10 @@ void InputMethodEngineIBus::Initialize(

const char* engine_name,

const char* extension_id,

const char* engine_id,

- const char* description,

const std::vector<std::string>& languages,

const std::vector<std::string>& layouts,

const GURL& options_page,

- const GURL& input_view,

- std::string* error) {

+ const GURL& input_view) {

DCHECK(observer) << "Observer must not be null.";

observer_ = observer;

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_ibus.h ('k') | chrome/browser/extensions/api/input_ime/OWNERS » ('j') | no next file with comments »