Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add OWNER file Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/input_method/input_method_engine.h" 5 #include "chrome/browser/chromeos/input_method/input_method_engine.h"
6 6
7 #include "chrome/browser/chromeos/input_method/input_method_engine_ibus.h" 7 #include "chrome/browser/chromeos/input_method/input_method_engine_ibus.h"
8 8
9 namespace chromeos { 9 namespace chromeos {
10 10
(...skipping 30 matching lines...) Expand all
41 is_cursor_visible(true), 41 is_cursor_visible(true),
42 is_vertical(false), 42 is_vertical(false),
43 show_window_at_composition(false) { 43 show_window_at_composition(false) {
44 } 44 }
45 45
46 InputMethodEngine::CandidateWindowProperty::~CandidateWindowProperty() { 46 InputMethodEngine::CandidateWindowProperty::~CandidateWindowProperty() {
47 } 47 }
48 48
49 InputMethodEngine::Observer::~Observer() { 49 InputMethodEngine::Observer::~Observer() {
50 } 50 }
51
52 InputMethodEngine* InputMethodEngine::CreateEngine(
53 InputMethodEngine::Observer* observer,
54 const char* engine_name,
55 const char* extension_id,
56 const char* engine_id,
57 const char* description,
58 const std::vector<std::string>& languages,
59 const std::vector<std::string>& layouts,
60 const GURL& options_page,
61 const GURL& input_view,
62 std::string* error) {
63
64 InputMethodEngineIBus* engine = new InputMethodEngineIBus();
65 engine->Initialize(observer,
66 engine_name,
67 extension_id,
68 engine_id,
69 description,
70 languages,
71 layouts,
72 options_page,
73 input_view,
74 error);
75 return engine;
76 }
77
78 } // namespace chromeos 51 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698