Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: chrome/browser/chromeos/input_method/input_method_engine.h

Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add OWNER file Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_ENGINE_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_ENGINE_H_
6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_ENGINE_H_ 6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_ENGINE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 // the surrounding text. The |offset| is relative position based on current 231 // the surrounding text. The |offset| is relative position based on current
232 // caret. 232 // caret.
233 // NOTE: Currently we are falling back to backspace forwarding workaround, 233 // NOTE: Currently we are falling back to backspace forwarding workaround,
234 // because delete_surrounding_text is not supported in Chrome. So this 234 // because delete_surrounding_text is not supported in Chrome. So this
235 // function is restricted for only preceding text. 235 // function is restricted for only preceding text.
236 // TODO(nona): Support full spec delete surrounding text. 236 // TODO(nona): Support full spec delete surrounding text.
237 virtual bool DeleteSurroundingText(int context_id, 237 virtual bool DeleteSurroundingText(int context_id,
238 int offset, 238 int offset,
239 size_t number_of_chars, 239 size_t number_of_chars,
240 std::string* error) = 0; 240 std::string* error) = 0;
241
242 // Create an IME engine.
243 static InputMethodEngine* CreateEngine(
244 InputMethodEngine::Observer* observer,
245 const char* engine_name,
246 const char* extension_id,
247 const char* engine_id,
248 const char* description,
249 const std::vector<std::string>& language,
250 const std::vector<std::string>& layouts,
251 const GURL& options_page,
252 const GURL& input_view,
253 std::string* error);
254 }; 241 };
255 242
256 } // namespace chromeos 243 } // namespace chromeos
257 244
258 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_ENGINE_H_ 245 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_ENGINE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698