Adds Embed() variant to ViewManagerService that takes ViewManagerClient

Adds Embed() variant to ViewManagerService that takes ViewManagerClient

This is for situations where an app wants to directly supply the
ViewManagerClient implementation.

R=msw@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/3b05b0b541233b90d2810b8a1969ddd459ff51c4

[msw, 2015-02-09 19:44:13]

lgtm with nits.

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
File services/view_manager/view_manager_service_apptest.cc (right):

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
services/view_manager/view_manager_service_apptest.cc:83: bool
Embed(ViewManagerService* vm, Id root_id) {
nit: rename EmbedUrl to avoid overloading the new Embed below?

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
services/view_manager/view_manager_service_apptest.cc:1337: // Create 1 and 2 in
the first connection and parent both to the root.
nit: This doesn't seem to create or add |2|, just |1|. (ditto below)

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
services/view_manager/view_manager_service_apptest.cc:1468: // Create 1 and 2 in
the first connection and parent both to the root.
nit: This doesn't seem to create or add |2|, just |1|. (ditto above)

[sky, 2015-02-09 20:16:09]

New patchsets have been uploaded after l-g-t-m from msw@chromium.org

[sky, 2015-02-09 20:25:35]

Committed patchset #4 (id:60001) manually as
3b05b0b541233b90d2810b8a1969ddd459ff51c4 (presubmit successful).

[hansmuller1, 2015-02-09 20:46:43]

hansmuller@google.com changed reviewers:
+ hansmuller@google.com

[hansmuller1, 2015-02-09 20:46:44]

https://codereview.chromium.org/905083002/diff/60001/mojo/services/view_manag...
File mojo/services/view_manager/public/interfaces/view_manager.mojom (right):

https://codereview.chromium.org/905083002/diff/60001/mojo/services/view_manag...
mojo/services/view_manager/public/interfaces/view_manager.mojom:116: //
|view_id|. The call fails if the originating connection did not create
I think you mean that the call returns (responds with) false.

[sky, 2015-02-10 00:12:59]

Just noticed I forgot to push these. Patch already landed.

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
File services/view_manager/view_manager_service_apptest.cc (right):

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
services/view_manager/view_manager_service_apptest.cc:83: bool
Embed(ViewManagerService* vm, Id root_id) {
On 2015/02/09 19:44:13, msw wrote:
> nit: rename EmbedUrl to avoid overloading the new Embed below?

Done.

https://codereview.chromium.org/905083002/diff/20001/services/view_manager/vi...
services/view_manager/view_manager_service_apptest.cc:1468: // Create 1 and 2 in
the first connection and parent both to the root.
On 2015/02/09 19:44:12, msw wrote:
> nit: This doesn't seem to create or add |2|, just |1|. (ditto above)

I nuked the comment (here and above). It wasn't really helpful.