Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: mojo/services/view_manager/public/cpp/view.h

Issue 905083002: Adds Embed() variant to ViewManagerService that takes ViewManagerClient (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: real comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/cpp/view.h
diff --git a/mojo/services/view_manager/public/cpp/view.h b/mojo/services/view_manager/public/cpp/view.h
index 07bc5b0c20ff7fe64a8d09fb777d3d2e33581337..d888ef0998d80b4260f9d45cda1615b7969636a8 100644
--- a/mojo/services/view_manager/public/cpp/view.h
+++ b/mojo/services/view_manager/public/cpp/view.h
@@ -122,11 +122,12 @@ class View {
// Focus.
void SetFocus();
- // Embedding.
+ // Embedding. See view_manager.mojom for details.
void Embed(const String& url);
void Embed(const String& url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services);
+ void Embed(ViewManagerClientPtr client);
protected:
// This class is subclassed only by test classes that provide a public ctor.

Powered by Google App Engine
This is Rietveld 408576698