Adds Embed() variant to ViewManagerService that takes ViewManagerClient

mojo/services/view_manager/public/interfaces/view_manager.mojom

Index: mojo/services/view_manager/public/interfaces/view_manager.mojom
diff --git a/mojo/services/view_manager/public/interfaces/view_manager.mojom b/mojo/services/view_manager/public/interfaces/view_manager.mojom
index 961b783b9783d9eb6d6ee3f9caa0f1b93bbb1603..86560ba2d5d2d4e468cb65ad9ab1c4565e404224 100644
--- a/mojo/services/view_manager/public/interfaces/view_manager.mojom
+++ b/mojo/services/view_manager/public/interfaces/view_manager.mojom
@@ -105,10 +105,16 @@ interface ViewManagerService {
   // Shows the surface in the specified view.
   SetViewSurfaceId(uint32 view_id, SurfaceId surface_id) => (bool success);
 
-  // Embeds the app for |url| in the specified view. More specifically this
-  // creates a new connection to the specified url, expecting to get a
-  // ViewManagerClient and configures it with the root view |view|. Fails
-  // if |view| was not created by this connection.
+  // A connection may grant access to a view from another connection by way of
+  // the embed functions. There are two variants of this call:
+  //
+  // . EmbedUrl: the ViewManager connects to the app at the supplied url and
+  //   asks it for a ViewManagerClient.
+  // . With the second variant a ViewManagerClient is directly supplied.
+  //
+  // In both cases the new ViewManagerClient is configured with a root of
+  // |view_id|. The call fails if the originating connection did not create

[hansmuller1, 2015/02/09 20:46:44]

I think you mean that the call returns (responds with) false.

+  // the view identified by |view_id|.
   //
   // A view may only be a root of one connection at a time. Subsequent calls to
   // Embed() for the same view result in the view being removed from the
@@ -129,10 +135,11 @@ interface ViewManagerService {
   // if a different app is subsequently embedded at |view_id| the
   // ServiceProvider connections to its client in the embedded app and any
   // services it provided are not broken and continue to be valid.
-  Embed(string url,
-        uint32 view_id,
-        ServiceProvider&? services,
-        ServiceProvider? exposed_services) => (bool success);
+  EmbedUrl(string url,
+           uint32 view_id,
+           ServiceProvider&? services,
+           ServiceProvider? exposed_services) => (bool success);
+  Embed(uint32 view_id, ViewManagerClient client) => (bool success);
 };
 
 // Changes to views are not sent to the connection that originated the