mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h - Issue 905083002: Adds Embed() variant to ViewManagerService that takes ViewManagerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

Issue 905083002: Adds Embed() variant to ViewManagerService that takes ViewManagerClient (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: real comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/view_manager/public/cpp/lib/view.cc ('k') | mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc » ('j') | mojo/services/view_manager/public/interfaces/view_manager.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

diff --git a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

index b3dd1fd231c1c9d2d6ad980afb2955123d7a1feb..c3a2ad5ac629d341499a46fee8986ba02d9d2b56 100644

--- a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

+++ b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

@@ -64,6 +64,7 @@ class ViewManagerClientImpl : public ViewManager,

Id view_id,

InterfaceRequest<ServiceProvider> services,

ServiceProviderPtr exposed_services);

+ void Embed(Id view_id, ViewManagerClientPtr client);

void set_change_acked_callback(const base::Callback<void(void)>& callback) {

change_acked_callback_ = callback;