Adds Embed() variant to ViewManagerService that takes ViewManagerClient

mojo/services/view_manager/public/interfaces/view_manager.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module mojo;
 
 import "geometry/public/interfaces/geometry.mojom";
 import "input_events/public/interfaces/input_events.mojom";
 import "mojo/public/interfaces/application/service_provider.mojom";
 import "native_viewport/public/interfaces/native_viewport.mojom";
@@ skipping 87 matching lines @@
 
   // Returns the views comprising the tree starting at |view_id|. |view_id| is
   // the first result in the return value, unless |view_id| is invalid, in which
   // case an empty vector is returned. The views are visited using a depth first
   // search (pre-order).
   GetViewTree(uint32 view_id) => (array<ViewData> views);
 
   // Shows the surface in the specified view.
   SetViewSurfaceId(uint32 view_id, SurfaceId surface_id) => (bool success);
 
-  // Embeds the app for |url| in the specified view. More specifically this
-  // creates a new connection to the specified url, expecting to get a
-  // ViewManagerClient and configures it with the root view |view|. Fails
-  // if |view| was not created by this connection.
+  // A connection may grant access to a view from another connection by way of
+  // the embed functions. There are two variants of this call:
+  //
+  // . EmbedUrl: the ViewManager connects to the app at the supplied url and
+  //   asks it for a ViewManagerClient.
+  // . With the second variant a ViewManagerClient is directly supplied.
+  //
+  // In both cases the new ViewManagerClient is configured with a root of
+  // |view_id|. The call fails if the originating connection did not create

[hansmuller1, 2015/02/09 20:46:44]

I think you mean that the call returns (responds with) false.

+  // the view identified by |view_id|.
   //
   // A view may only be a root of one connection at a time. Subsequent calls to
   // Embed() for the same view result in the view being removed from the
   // currently embedded app. The embedded app is told this by way of
   // OnViewDeleted().
   //
   // The embedder can detect when the embedded app disconnects by way of
   // OnEmbeddedAppDisconnected().
   //
   // When a connection embeds an app the connection no longer has priviledges
   // to access or see any of the children of the view. If the view had existing
   // children the children are removed. The one exception is the root
   // connection.
   //
   // |services| encapsulates services offered by the embedder to the embedded
   // app alongside this Embed() call. |exposed_services| provides a means for
   // the embedder to connect to services exposed by the embedded app. Note that
   // if a different app is subsequently embedded at |view_id| the
   // ServiceProvider connections to its client in the embedded app and any
   // services it provided are not broken and continue to be valid.
-  Embed(string url,
-        uint32 view_id,
-        ServiceProvider&? services,
-        ServiceProvider? exposed_services) => (bool success);
+  EmbedUrl(string url,
+           uint32 view_id,
+           ServiceProvider&? services,
+           ServiceProvider? exposed_services) => (bool success);
+  Embed(uint32 view_id, ViewManagerClient client) => (bool success);
 };
 
 // Changes to views are not sent to the connection that originated the
 // change. For example, if connection 1 changes the bounds of a view by calling
 // SetBounds(), connection 1 does not receive OnViewBoundsChanged().
 interface ViewManagerClient {
   // Invoked when the client application has been embedded at |root|.
   // See Embed() on ViewManagerService for more details. |view_manager_service|
   // will be a handle back to the view manager service, unless the connection is
   // to the WindowManager in which case it will be null.
@@ skipping 53 matching lines @@
   // NOTE: This is not invoked if OnViewVisibilityChanged() is invoked.
   OnViewDrawnStateChanged(uint32 view, bool drawn);
 
   // Invoked when a view property is changed. If this change is a removal,
   // |new_data| is null.
   OnViewSharedPropertyChanged(uint32 view, string name, array<uint8>? new_data);
 
   // Invoked when an event is targeted at the specified view.
   OnViewInputEvent(uint32 view, mojo.Event event) => ();
 };