Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 894013002: patch from issue 886233004 at patchset 40001 (http://crrev.com/886233004#ps40001) (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

patch from issue 886233004 at patchset 40001 (http://crrev.com/886233004#ps40001) ... with changes proposed in the review. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b9eb4ac0f1c29d6fe10ad7ff81ed8326ac1ea043

Patch Set 1 #

Patch Set 2 : nogpu #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -176 lines) Patch
M dm/DM.cpp View 1 5 chunks +15 lines, -7 lines 0 comments Download
M dm/DMGpuSupport.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M dm/DMSrcSink.h View 11 chunks +13 lines, -13 lines 0 comments Download
M dm/DMSrcSink.cpp View 13 chunks +20 lines, -13 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +5 lines, -25 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/GrGpu.h View 7 chunks +54 lines, -39 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrResourceCache2.cpp View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +75 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
lgtm... does the line overwrite stuff conflict with the gpu stats logging when run w/out ...
5 years, 10 months ago (2015-02-03 01:33:44 UTC) #2
mtklein
On 2015/02/03 01:33:44, bsalomon wrote: > lgtm... does the line overwrite stuff conflict with the ...
5 years, 10 months ago (2015-02-03 01:52:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894013002/1
5 years, 10 months ago (2015-02-03 01:53:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1913)
5 years, 10 months ago (2015-02-03 01:55:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894013002/40001
5 years, 10 months ago (2015-02-03 02:19:27 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 02:26:06 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b9eb4ac0f1c29d6fe10ad7ff81ed8326ac1ea043

Powered by Google App Engine
This is Rietveld 408576698